8000 refactor: rename _docs_proto from DocumentArray by JoanFM · Pull Request #2605 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: rename _docs_proto from DocumentArray #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

refactor: rename _docs_proto from DocumentArray #2605

merged 1 commit into from
Jun 10, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 9, 2021

Changes introcued
Calling _docs_proto leads to think that these are protobuf objects, but they are actually different type of DocumentViews

@JoanFM JoanFM requested a review from a team as a code owner June 9, 2021 15:31
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Jun 9, 2021
@codecov
Copy link
codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #2605 (b57a681) into master (0b41d08) will increase coverage by 0.20%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2605      +/-   ##
==========================================
+ Coverage   87.22%   87.42%   +0.20%     
==========================================
  Files         153      153              
  Lines        9602     9602              
==========================================
+ Hits         8375     8395      +20     
+ Misses       1227     1207      -20
Flag Coverage Δ
daemon 46.57% <20.00%> (ø)
jina 87.50% <82.85%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/document.py 84.32% <80.64%> (ø)
jina/types/arrays/chunk.py 92.59% <100.00%> (ø)
jina/types/arrays/match.py 95.23% <100.00%> (ø)
jina/peapods/pods/compound.py 90.97% <0.00%> (+1.50%) ⬆️
jina/peapods/peas/__init__.py 96.77% <0.00%> (+2.41%) ⬆️
jina/peapods/pods/__init__.py 90.03% <0.00%> (+4.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b41d08...b57a681. Read the comment docs.

@hanxiao hanxiao merged commit 7705fbb into master Jun 10, 2021
@hanxiao hanxiao deleted the rename-docs-proto branch June 10, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbp davidbp Awaiting requested review from davidbp

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @hanxiao @jina-bot
0