8000 refactor: refactor optimizer parameter by JoanFM · Pull Request #2575 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: refactor optimizer parameter #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2021
Merged

refactor: refactor optimizer parameter #2575

merged 2 commits into from
Jun 7, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 7, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner June 7, 2021 14:09
@JoanFM JoanFM requested review from Roshanjossey and numb3r3 June 7, 2021 14:09
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Jun 7, 2021
bwanglzu
bwanglzu reviewed Jun 7, 2021
View reviewed changes
@codecov
Copy link
codecov bot commented Jun 7, 2021 •
edited
Loading

Codecov Report

Merging #2575 (87995cb) into master (226977c) will decrease coverage by 4.71%.
The diff coverage is 73.33%.

❗ Current head 87995cb differs from pull request most recent head f1a93cf. Consider uploading reports for the commit f1a93cf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
- Coverage   85.97%   81.26%   -4.72%     
==========================================
  Files         152      152              
  Lines        9505     9505              
==========================================
- Hits         8172     7724     -448     
- Misses       1333     1781     +448
Flag Coverage Δ
daemon 83.11% <ø> (+36.47%) ⬆️
jina 81.13% <73.33%> (-4.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/optimizers/flow_runner.py 97.67% <ø> (ø)
jina/optimizers/parameters.py 67.30% <66.66%> (-0.20%) ⬇️
jina/optimizers/__init__.py 95.69% <100.00%> (+8.07%) ⬆️
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/peapods/runtimes/jinad/client.py 20.43% <0.00%> (-62.05%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 35.71% <0.00%> (-60.72%) ⬇️
jina/jaml/parsers/flow/v1.py 48.14% <0.00%> (-44.45%) ⬇️
jina/logging/formatter.py 58.82% <0.00%> (-41.18%) ⬇️
jina/logging/profile.py 66.40% <0.00%> (-29.60%) ⬇️
jina/peapods/runtimes/zmq/base.py 51.78% <0.00%> (-28.58%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226977c...f1a93cf. Read the comment docs.

@JoanFM JoanFM requested a review from bwanglzu June 7, 2021 15:19
bwanglzu
bwanglzu approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JoanFM JoanFM merged commit 502a7db into master Jun 7, 2021
@JoanFM JoanFM deleted the test-optimizer branch June 7, 2021 15:25
alanthssss pushed a commit that referenced this pull request Jun 9, 2021
refactor: refactor optimizer parameter (#2575)
0e22cb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwanglzu bwanglzu bwanglzu approved these changes

@Roshanjossey Roshanjossey Awaiting requested review from Roshanjossey

@numb3r3 numb3r3 Awaiting requested review from numb3r3

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @bwanglzu @jina-bot
0