8000 feat: update example models for better running versions by maximilianwerk · Pull Request #2561 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: update example models for better running versions #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2021
Merged

feat: update example models for better running versions #2561

merged 2 commits into from
Jun 4, 2021

Conversation

maximilianwerk
Copy link
Member

Updated helloworld models in order to reach better quality.

@maximilianwerk maximilianwerk requested a review from a team as a code owner June 4, 2021 10:41
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping labels Jun 4, 2021
@codecov
Copy link
codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

Merging #2561 (5ed2d11) into master (6363bb2) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
+ Coverage   85.97%   86.21%   +0.24%     
==========================================
  Files         152      152              
  Lines        9503     9503              
==========================================
+ Hits         8170     8193      +23     
+ Misses       1333     1310      -23
Flag Coverage Δ
daemon 46.63% <ø> (ø)
jina 86.21% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helloworld/chatbot/executors.py 0.00% <ø> (ø)
jina/helloworld/multimodal/executors.py 90.26% <ø> (ø)
jina/flow/base.py 90.59% <0.00%> (+0.91%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.80% <0.00%> (+0.95%) ⬆️
jina/peapods/runtimes/jinad/client.py 87.59% <0.00%> (+5.10%) ⬆️
jina/peapods/pods/compound.py 89.47% <0.00%> (+7.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6363bb2...5ed2d11. Read the comment docs.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Jun 4, 2021
@hanxiao hanxiao merged commit 14a0a5d into master Jun 4, 2021
@hanxiao hanxiao deleted the feat-update-example-models < 75AE /span> branch June 4, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsergiy imsergiy Awaiting requested review from imsergiy

@jakobkruse1 jakobkruse1 Awaiting requested review from jakobkruse1

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximilianwerk @hanxiao @jina-bot
0