test: added a test for docmatrix in the tail pea #2537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
Codecov Report
@@ Coverage Diff @@
## master #2537 +/- ##
==========================================
+ Coverage 85.67% 86.29% +0.61%
==========================================
Files 152 152
Lines 9462 9503 +41
==========================================
+ Hits 8107 8201 +94
+ Misses 1355 1302 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cristianmtr
previously approved these changes
Jun 1, 2021
|
(1, 2) should work now. What I am not sure about with |
JoanFM
previously requested changes
Jun 1, 2021
1a9f369 to
921306b
Compare
maximilianwerk
commented
Jun 2, 2021
cristianmtr
reviewed
Jun 2, 2021
| @pytest.mark.timeout(5) | ||
| @pytest.mark.parametrize('num_replicas, num_shards', [(1, 1), (2, 2)]) | ||
| def test_sharding_tail_pea(num_replicas, num_shards): | ||
| """TODO(Maximilian): Make (1, 2) and (2, 1) also workable""" |
There was a problem hiding this comment.
opened an issue for this #2547
cristianmtr
approved these changes
Jun 2, 2021
JoanFM
pushed a commit
that referenced
this pull request
Jun 3, 2021
* test: added a test for docmatrix in the tail pea * test: added also merge before in follow up pod * test: added multimodal version of uses before * test: fix parametrization and init param * ci: ignore test file in black * test: added black back to tests Co-authored-by: cristian <cristianmtr@users.noreply.github.com> Co-authored-by: cristian mtr <cristian.mitroi@jina.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test showcasing, how a
MatchMergerin a TailPea could look like. Beware, that replica/sharding for(1,2)and(2,1)are broken. That needs to be fixed before 2.0 release.