8000 test: added pymodules import test back by maximilianwerk · Pull Request #2536 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: added pymodules import test back #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

maximilianwerk
Copy link
Member

adding integration test for pymodules back. One is not needed anymore, since full module discovery works, when __init__.py is added to pymodules

@maximilianwerk maximilianwerk requested a review from a team as a code owner June 1, 2021 11:50
@jina-bot jina-bot added size/M area/testing This issue/PR affects testing labels Jun 1, 2021
@maximilianwerk maximilianwerk mentioned this pull request Jun 1, 2021
36 tasks
@codecov
Copy link
codecov bot commented Jun 1, 2021

Codecov Report

Merging #2536 (6e1b846) into master (7d6c8ff) will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
+ Coverage   85.67%   86.07%   +0.39%     
==========================================
  Files         152      152              
  Lines        9462     9462              
==========================================
+ Hits         8107     8144      +37     
+ Misses       1355     1318      -37     
Flag Coverage Δ
daemon 46.82% <ø> (ø)
jina 86.05% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 90.59% <0.00%> (+0.91%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.80% <0.00%> (+0.95%) ⬆️
jina/importer.py 80.40% <0.00%> (+1.00%) ⬆️
jina/peapods/pods/compound.py 89.47% <0.00%> (+21.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6c8ff...6e1b846. Read the comment docs.

@hanxiao hanxiao merged commit f455391 into master Jun 2, 2021
@hanxiao hanxiao deleted the test-pymodules-import branch June 2, 2021 03:07
JoanFM pushed a commit that referenced this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0