fix: naming of peas replicas in logs #2508
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2508 +/- ##
==========================================
+ Coverage 83.19% 86.27% +3.07%
==========================================
Files 152 152
Lines 9445 9462 +17
==========================================
+ Hits 7858 8163 +305
+ Misses 1587 1299 -288
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hey @properGrammar Thanks a lot for persisting! However, I tried running some Flows locally and we noticed that the logs are bit worse to read now. However, reducing the "replica" to just "rep" made it much better. Can you adjust your PR to that instead perhaps? Also remember to adjust the tests |
|
You're welcome, @cristianmtr ! Thanks for working with me to help me learn how to submit things per Jina's spec. I've made the change you requested (and agree that it preserves readability) so hopefully it works for you. Cheers. |
There was a problem hiding this comment.
As for the docker login error in CI: Check run here,
@hanxiao @nan-wang @deepankarm could you plz help check the secrets of docker login?
DOCKERHUB_DEVBOT_USERDOCKERHUB_DEVBOT_TOKEN
|
cristianmtr approved these changes 9 hours ago 🎉😊 |
|
https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow |
* fix: naming of peas replicas in logs * fix: change replica- to rep- Co-authored-by: Graham Arthur Mackenzie <gmackenzie3@gatech.edu>
Intended to fix #2363
This is a 3nd, cleaner try at #2382 and #2418 lol
cc: @cristianmtr @maximilianwerk @JoanFM