8000 fix: missing imports in code snippet by davidbp · Pull Request #2488 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: missing imports in code snippet #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

fix: missing imports in code snippet #2488

merged 1 commit into from
May 26, 2021

Conversation

davidbp
Copy link
Contributor
@davidbp davidbp commented May 26, 2021

No description provided.

@davidbp davidbp requested a review from a team as a code owner May 26, 2021 13:43
@jina-bot jina-bot added size/XS area/housekeeping This issue/PR is housekeeping labels May 26, 2021
bwanglzu
bwanglzu approved these changes May 26, 2021
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
codecov bot commented May 26, 2021 •
edited
Loading

Codecov Report

Merging #2488 (870b9d5) into master (9a8d842) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
- Coverage   83.43%   83.36%   -0.08%     
==========================================
  Files         152      152              
  Lines        9425     9425              
==========================================
- Hits         7864     7857       -7     
- Misses       1561     1568       +7
Flag Coverage Δ
daemon 47.03% <ø> (ø)
jina 83.17% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/peas/__init__.py 94.26% <0.00%> (-2.46%) ⬇️
jina/peapods/pods/compound.py 90.00% <0.00%> (-1.54%) ⬇️
jina/helper.py 80.07% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8d842...870b9d5. Read the comment docs.

@hanxiao hanxiao merged commit 86d6123 into master May 26, 2021
@hanxiao hanxiao deleted the fix-missing-imports-sklearn branch May 26, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleeit mapleeit mapleeit approved these changes

@bwanglzu bwanglzu bwanglzu approved these changes

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

Assignees
No one assigned
Labels
area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidbp @mapleeit @bwanglzu @hanxiao @jina-bot
0