refactor: remove module from typename #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoanFM
suggested changes
May 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #2486 +/- ##
==========================================
+ Coverage 84.28% 87.07% +2.79%
==========================================
Files 153 153
Lines 9449 9449
==========================================
+ Hits 7964 8228 +264
+ Misses 1485 1221 -264
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JoanFM
suggested changes
May 26, 2021
JoanFM
reviewed
Jun 7, 2021
| py_metas_name = py_executor.metas.name | ||
| py_typename = typename(py_executor) | ||
|
|
||
| assert jaml_metas_name == py_metas_name |
There was a problem hiding this comment.
and what is the expected value for each of these?
JoanFM
previously approved these changes
Jun 7, 2021
|
make sure u rebase with master to pass checks |
added 7 commits
June 7, 2021 17:43
<
8000
div class="d-flex flex-md-row flex-column">
649e059 to
d72f2d9
Compare
I don't think the failing checks are caused by the rebase. I just rebased and the problem is still there. |
…ace-index-folder-names
JoanFM
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following problems occurred when running examples in the 2.0 API:
When indexing or searching by yml file Flow.load_config(...), the index files are stored in
When I do the same using the Python syntax Flow().add(...), then the index files are stored in
This causes problems when you want to index via yml file, but search using the Python only interface.
This PR adresses this problem by removing the module name from the folder name.