feat: add mindspore to cookbook #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
+ Coverage 83.46% 83.52% +0.05%
==========================================
Files 152 152
Lines 9425 9425
==========================================
+ Hits 7867 7872 +5
+ Misses 1558 1553 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nan-wang
previously requested changes
May 26, 2021
.github/2.0/cookbooks/Executor.md
Outdated
| class MindsporeMwuExecutor(Executor): | ||
| def __init__(self, **kwargs): | ||
| super().__init__() | ||
| context.set_context(mode=context.PYNATIVE_MODE, device_target="CPU") |
There was a problem hiding this comment.
Suggested change
| context.set_context(mode=context.PYNATIVE_MODE, device_target="CPU") | |
| context.set_context(mode=context.PYNATIVE_MODE, device_target='CPU') |
JoanFM
suggested changes
May 26, 2021
.github/2.0/cookbooks/Executor.md
Outdated
| @requests | ||
| def encode(self, docs, **kwargs): | ||
| for doc in docs: | ||
| input_tensor = Tensor( |
There was a problem hiding this comment.
can u make it not pass black? I think it looks leaner?
.github/2.0/cookbooks/Executor.md
Outdated
| def __init__(self, **kwargs): | ||
| super().__init__() | ||
| context.set_context(mode=context.PYNATIVE_MODE, device_target='CPU') | ||
| self.dims = 5 |
…into feat-add-mindspore
JoanFM
approved these changes
May 26, 2021
JoanFM
suggested changes
May 26, 2021
Co-authored-by: Joan Fontanals <joan.martinez@jina.ai>
JoanFM
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mindspore to Jina 2.0 cookbook. tested .