8000 feat: improve REST interface with better data models by hanxiao · Pull Request #2442 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: improve REST interface with better data models #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2021
Merged

feat: improve REST interface with better data models #2442

merged 3 commits into from
May 19, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented May 19, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner May 19, 2021 06:37
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality component/client component/peapod labels May 19, 2021
@codecov
Copy link
codecov bot commented May 19, 2021 •
edited
Loading

Codecov Report

Merging #2442 (c74a319) into master (d02d82d) will decrease coverage by 4.51%.
The diff coverage is 94.73%.

❗ Current head c74a319 differs from pull request most recent head 0ae4e67. Consider uploading reports for the commit 0ae4e67 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2442      +/-   ##
==========================================
- Coverage   83.54%   79.02%   -4.52%     
==========================================
  Files         150      150              
  Lines        9358     9359       +1     
==========================================
- Hits         7818     7396     -422     
- Misses       1540     1963     +423
Flag Coverage Δ
daemon 47.09% <5.26%> (-0.01%) ⬇️
jina 78.53% <94.73%> (-4.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/asyncio/rest/app.py 87.82% <83.33%> (-0.78%) ⬇️
jina/clients/request/__init__.py 100.00% <100.00%> (ø)
jina/clients/request/asyncio.py 83.33% <100.00%> (ø)
jina/peapods/runtimes/asyncio/rest/models.py 100.00% <100.00%> (ø)
jina/schemas/pod.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/flow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/meta.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/executor.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/export_api.py 0.00% <0.00%> (-87.50%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02d82d...0ae4e67. Read the comment docs.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label May 19, 2021
@hanxiao hanxiao merged commit 0c6d0ac into master May 19, 2021
@hanxiao hanxiao deleted the feat-improve-rest branch May 19, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbp davidbp Awaiting requested review from davidbp

@jacobowitz jacobowitz Awaiting requested review from jacobowitz

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/peapod size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0