8000 fix: support generator by JoanFM · Pull Request #2445 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 fix: support generator #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2021
Merged

fix: support generator #2445

merged 4 commits into from
May 20, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented May 19, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner May 19, 2021 08:36
@JoanFM JoanFM requested review from imsergiy and deepankarm May 19, 2021 08:36
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/type labels May 19, 2021
@hanxiao
Copy link
Member
hanxiao commented May 19, 2021

is this next() generator-specific, otherwise this will affect iterator as well, not only generator

@JoanFM
Copy link
Contributor Author
JoanFM commented May 19, 2021

is this next() generator-specific, otherwise this will affect iterator as well, not only generator

maybe there is a safer place

@JoanFM JoanFM force-pushed the fix-darray-type branch from 9b9aefc to 201a773 Compare May 19, 2021 09:06
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing and removed size/XS labels May 19, 2021
@codecov
Copy link
8000
codecov bot commented May 19, 2021

Codecov Report

Merging #2445 (6fa38bf) into master (d91f62f) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2445      +/-   ##
==========================================
+ Coverage   83.17%   83.57%   +0.39%     
==========================================
  Files         150      150              
  Lines        9367     9369       +2     
==========================================
+ Hits         7791     7830      +39     
+ Misses       1576     1539      -37     
Flag Coverage Δ
daemon 47.10% <66.66%> (+<0.01%) ⬆️
jina 83.39% <100.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/document.py 85.13% <100.00%> (+0.13%) ⬆️
jina/peapods/pods/__init__.py 85.40% <0.00%> (-4.66%) ⬇️
jina/peapods/runtimes/zmq/zed.py 93.83% <0.00%> (+0.94%) ⬆️
jina/flow/base.py 92.51% <0.00%> (+0.96%) ⬆️
jina/peapods/zmq/__init__.py 85.20% <0.00%> (+2.07%) ⬆️
jina/peapods/peas/__init__.py 96.72% <0.00%> (+2.45%) ⬆️
jina/docker/hubapi/remote.py 97.01% <0.00%> (+2.98%) ⬆️
jina/clients/base.py 80.43% <0.00%> (+3.26%) ⬆️
jina/peapods/pods/compound.py 91.53% <0.00%> (+23.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91f62f...6fa38bf. Read the comment docs.

@JoanFM JoanFM force-pushed the fix-darray-type branch from 5173096 to 1af6ba5 Compare May 19, 2021 09:48
@jina-bot jina-bot added the area/housekeeping This issue/PR is housekeeping label May 19, 2021
@hanxiao hanxiao merged commit 658aea7 into master May 20, 2021
@hanxiao hanxiao deleted the fix-darray-type branch May 20, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0