8000 fix: change async client function's return type by Kelton8Z · Pull Request #2386 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: change async client function's return type #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 10, 2021
Merged

fix: change async client function's return type #2386

merged 4 commits into from
May 10, 2021

Conversation

Kelton8Z
Copy link
Contributor
@Kelton8Z Kelton8Z commented May 7, 2021

No description provided.

@Kelton8Z Kelton8Z requested a review from a team as a code owner May 7, 2021 08:35
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/client labels May 7, 2021
@Kelton8Z Kelton8Z requested review from JoanFM and nan-wang and removed request for cristianmtr May 7, 2021 08:35
@Kelton8Z
Copy link
Contributor Author
Kelton8Z commented May 7, 2021

close #2063 without hub submodule conflict

@github-actions
Copy link
github-actions bot commented May 7, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 962, delta to last 3 avg.: +0%
  • 😶 query QPS at 14, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 962 14
1.2.1 956 14
1.2.0 950 13

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented May 8, 2021 •
edited
Loading

Codecov Report

Merging #2386 (774b9d5) into master (b829338) will increase coverage by 0.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2386      +/-   ##
==========================================
+ Coverage   87.66%   88.45%   +0.78%     
==========================================
  Files         230      230              
  Lines       12301    12302       +1     
==========================================
+ Hits        10784    10882      +98     
+ Misses       1517     1420      -97
Flag Coverage Δ
daemon 50.32% <100.00%> (+0.07%) ⬆️
jina 88.58% <100.00%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/asyncio.py 78.04% <100.00%> (+0.54%) ⬆️
jina/peapods/peas/__init__.py 95.08% <0.00%> (-2.34%) ⬇️
jina/peapods/pods/compoundpod.py 90.15% <0.00%> (-1.58%) ⬇️
jina/flow/base.py 91.48% <0.00%> (+0.48%) ⬆️
jina/peapods/pods/__init__.py 85.71% <0.00%> (+0.68%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 96.42% <0.00%> (+1.78%) ⬆️
jina/executors/indexers/__init__.py 100.00% <0.00%> (+2.10%) ⬆️
jina/peapods/zmq/__init__.py 85.37% <0.00%> (+2.38%) ⬆️
jina/clients/base.py 82.64% <0.00%> (+2.47%) ⬆️
jina/types/message/common.py 100.00% <0.00%> (+5.88%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b829338...774b9d5. Read the comment docs.

nan-wang
nan-wang approved these changes May 10, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 199d54b into master May 10, 2021
@nan-wang nan-wang deleted the fix-client-return-type branch May 10, 2021 03:06
@nan-wang nan-wang mentioned this pull request May 10, 2021
Closed
@nan-wang nan-wang linked an issue May 10, 2021 that may be closed by this pull request
run_async returns future - not None #2063
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/client size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run_async returns future - not None
3 participants
@Kelton8Z @nan-wang @jina-bot
0