8000 fix: broken link to extra deps documentation by akanz1 · Pull Request #2376 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: broken link to extra deps documentation #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2021
Merged

fix: broken link to extra deps documentation #2376

merged 2 commits into from
May 6, 2021

Conversation

akanz1
Copy link
Contributor
@akanz1 akanz1 commented May 3, 2021

No description provided.

@akanz1 akanz1 requested a review from a team as a code owner May 3, 2021 07:37
@codecov
Copy link
codecov bot commented May 3, 2021

Codecov Report

Merging #2376 (ecfa571) into master (0b2cc42) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2376      +/-   ##
==========================================
+ Coverage   88.50%   88.82%   +0.32%     
==========================================
  Files         230      230              
  Lines       12135    12135              
==========================================
+ Hits        10740    10779      +39     
+ Misses       1395     1356      -39     
Flag Coverage Δ
daemon 50.38% <ø> (ø)
jina 88.88% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/docker/hubio.py 84.52% <0.00%> (ø)
jina/executors/__init__.py 92.74% <0.00%> (+0.40%) ⬆️
jina/flow/base.py 92.26% <0.00%> (+0.74%) ⬆️
jina/docker/hubapi/local.py 90.10% <0.00%> (+1.09%) ⬆️
jina/peapods/runtimes/jinad/client.py 87.59% <0.00%> (+5.10%) ⬆️
jina/peapods/pods/compoundpod.py 90.97% <0.00%> (+20.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2cc42...ecfa571. Read the comment docs.

Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang
Copy link
Member
nan-wang commented May 3, 2021

recheckcla

@github-actions
Copy link
github-actions bot commented May 3, 2021

Jina CLA check ✅ All Contributors have signed the CLA.

@akanz1
Copy link
Contributor Author
akanz1 commented May 3, 2021

I have read the CLA Document and I hereby sign the CLA

@bwanglzu
Copy link
Member
bwanglzu commented May 5, 2021

@akanz1 can you merge the latest master branch into your feature branch to pass the docstring check?

@github-actions
Copy link
github-actions bot commented May 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1071, delta to last 3 avg.: -1%
  • 😶 query QPS at 18, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1071 18
1.2.1 1095 18
1.2.0 1082 17

Backed by latency-tracking. Further commits will update this comment.

@akanz1
Copy link
Contributor Author
akanz1 commented May 5, 2021

@bwanglzu done, seems to pass now

@bwanglzu bwanglzu merged commit da53b73 into jina-ai:master May 6, 2021
@jina-ai jina-ai locked and limited conversation to collaborators May 6, 2021
Sign up for free 6DD3 to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0