8000 refactor: improve the readability by nan-wang · Pull Request #2357 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: improve the readability #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

refactor: improve the readability #2357

merged 1 commit into from
Apr 28, 2021

Conversation

nan-wang
Copy link
Member

improve the readability

@nan-wang nan-wang requested a review from a team as a code owner April 28, 2021 02:42
@github-actions
Copy link

This PR closes: #1

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/driver labels Apr 28, 2021
@nan-wang nan-wang mentioned this pull request Apr 28, 2021
Closed
@codecov
Copy link
codecov bot commented Apr 28, 2021 •
edited
Loading

Codecov Report

Merging #2357 (2a798ff) into master (3a54b8d) will decrease coverage by 0.00%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
- Coverage   90.83%   90.82%   -0.01%     
==========================================
  Files         223      223              
  Lines       12032    12036       +4     
==========================================
+ Hits        10929    10932       +3     
- Misses       1103     1104       +1
Flag Coverage Δ
daemon 50.77% <13.04%> (-0.02%) ⬇️
jina 90.99% <82.60%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 83.72% <ø> (ø)
jina/drivers/__init__.py 89.15% <80.00%> (-1.05%) ⬇️
jina/drivers/encode.py 100.00% <100.00%> (ø)
jina/drivers/predict.py 93.47% <100.00%> (ø)
jina/drivers/querylang/select.py 89.65% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26d5eb...2a798ff. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1022, delta to last 3 avg.: +5%
  • 😶 query QPS at 14, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1022 14
1.1.10 974 13
1.1.9 958 14

Backed by latency-tracking. Further commits will update this comment.

@nan-wang nan-wang requested a review from JoanFM April 28, 2021 03:08
@JoanFM JoanFM merged commit df871ab into master Apr 28, 2021
@JoanFM JoanFM deleted the refactor-drivers-readability-1 branch April 28, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-hoenicke florian-hoenicke florian-hoenicke approved these changes

@JoanFM JoanFM JoanFM approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/driver size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nan-wang @florian-hoenicke @JoanFM @jina-bot
0