test: add tests for issue 2295 #2306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
+ Coverage 90.83% 90.86% +0.03%
==========================================
Files 222 222
Lines 11740 11740
==========================================
+ Hits 10664 10668 +4
+ Misses 1076 1072 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Test with proposed quick fix for #2295 |
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
|
Closes #2295 ? |
|
|
||
|
|
||
| class SearchDocIndexer(BinaryPbIndexer): | ||
| def query(self, jina_id: str = None, mongo_ids: List[str] = None): |
There was a problem hiding this comment.
Why only 1 jina_id but multiple mongo_ids?
There was a problem hiding this comment.
this is provided by the client, is just an example
|
|
||
| def post_init(self): | ||
| super().post_init() | ||
| self.name = 'doc_idx_file' |
There was a problem hiding this comment.
maybe make a comment for this to explain why it was necessary and link to the issue that describes the underlying problem
d8d5ab5 to
b90b31
9F01
4
Compare
No description provided.