8000 feat: add link to run in colab by FionnD · Pull Request #2270 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add link to run in colab #2270

New issue
Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2021
Merged

feat: add link to run in colab #2270

merged 2 commits into from
Apr 7, 2021

Conversation

FionnD
Copy link
Contributor
@FionnD FionnD commented Apr 1, 2021

This PR replaces each binder link with a link to the same notebook in colab.

This PR can not be merged until jina-ai/jupyter-notebooks#8 is merged.

@FionnD FionnD requested review from hanxiao and nan-wang April 1, 2021 08:03
@github-actions
Copy link
github-actions bot commented Apr 1, 2021

This PR closes: #2

@jina-bot jina-bot added size/S area/housekeeping This issue/PR is housekeeping labels Apr 1, 2021
@codecov
Copy link
codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #2270 (73f2e5c) into master (d9ca73d) will increase coverage by 0.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
+ Coverage   87.24%   87.95%   +0.70%     
==========================================
  Files         209      209              
  Lines       11416    11416              
==========================================
+ Hits         9960    10041      +81     
+ Misses       1456     1375      -81
Flag Coverage Δ
daemon 51.12% <ø> (-27.44%) ⬇️
jina 88.23% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/indexers/keyvalue.py 99.26% <0.00%> (+0.73%) ⬆️
jina/peapods/peas/__init__.py 93.69% <0.00%> (+0.90%) ⬆️
jina/flow/base.py 60.86% <0.00%> (+1.02%) ⬆️
jina/peapods/pods/helper.py 97.89% <0.00%> (+1.05%) ⬆️
jina/flow/builder.py 95.52% <0.00%> (+1.49%) ⬆️
jina/peapods/runtimes/asyncio/base.py 92.10% <0.00%> (+2.63%) ⬆️
jina/flow/mixin/crud.py 89.65% <0.00%> (+3.44%) ⬆️
jina/peapods/runtimes/asyncio/rest/app.py 85.92% <0.00%> (+5.92%) ⬆️
jina/drivers/querylang/select.py 72.41% <0.00%> (+6.89%) ⬆️
jina/peapods/runtimes/jinad/client.py 80.29% <0.00%> (+23.35%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18b232...73f2e5c. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Apr 1, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 999, delta to last 3 avg.: +0%
  • 😶 query QPS at 14, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 999 14
1.1.0 999 14
1.0.16 989 14

Backed by latency-tracking. Further commits will update this comment.

@bwanglzu
Copy link
Member
bwanglzu commented Apr 2, 2021 •
edited
Loading

@FionnD I merged master back to your feature branch to allow ci pass

nan-wang
nan-wang approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@FionnD
Copy link
Contributor Author
FionnD commented Apr 6, 2021

@hanxiao is there any issue with merging this?

@hanxiao hanxiao merged commit 5fbc30a into master Apr 7, 2021
@hanxiao hanxiao deleted the FionnD-patch-2 branch April 7, 2021 04:17
@FionnD FionnD linked an issue Apr 7, 2021 that may be closed by this pull request
Moving notebooks to Colab #2265
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving notebooks to Colab
5 participants
@FionnD @bwanglzu @nan-wang @hanxiao @jina-bot
0