8000 feat(pod): add reload mechanism to pod by hanxiao · Pull Request #2261 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(pod): add reload mechanism to pod #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 31, 2021
Merged

feat(pod): add reload mechanism to pod #2261

merged 13 commits into from
Mar 31, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Mar 31, 2021

This PR add a new argument --load-interval, allow Executor load dynamically while querying.

--dump-interval dumps indexed data to workspace at every x seconds.
--load-interval reload the Executor in the Pod at every x seconds.

By default do not reload executor.

@hanxiao hanxiao requested a review from a team as a code owner March 31, 2021 05:44
@jina-bot jina-bot added size/L area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/docker component/executor component/jaml component/logging component/peapod component/resource component/type executor/indexer executor/meta labels Mar 31, 2021
@codecov
Copy link
codecov bot commented Mar 31, 2021

Codecov Report

Merging #2261 (c6d2799) into master (c861055) will increase coverage by 0.10%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
+ Coverage   90.54%   90.64%   +0.10%     
==========================================
  Files         209      209              
  Lines       11311    11335      +24     
==========================================
+ Hits        10241    10275      +34     
+ Misses       1070     1060      -10     
Flag Coverage Δ
daemon 51.20% <48.64%> (+0.02%) ⬆️
jina 91.11% <97.29%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/docker/hubapi/local.py 89.01% <ø> (ø)
jina/helper.py 83.75% <ø> (ø)
jina/logging/profile.py 96.09% <ø> (ø)
jina/peapods/runtimes/container/__init__.py 85.71% <0.00%> (ø)
jina/docker/hubio.py 82.97% <100.00%> (ø)
jina/executors/decorators.py 94.24% <100.00%> (ø)
jina/executors/indexers/__init__.py 97.87% <100.00%> (+0.04%) ⬆️
jina/executors/indexers/keyvalue.py 99.26% <100.00%> (+0.04%) ⬆️
jina/executors/indexers/vector.py 96.63% <100.00%> (+0.10%) ⬆️
jina/jaml/__init__.py 96.37% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf5306...c6d2799. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Mar 31, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1305, delta to last 3 avg.: +2%
  • 😶 query QPS at 21, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1305 21
1.1.0 1297 20
1.0.16 1253 21

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 0946a46 into master Mar 31, 2021
@hanxiao hanxiao deleted the hanxiao-devel branch March 31, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/docker component/executor component/jaml component/logging component/peapod component/resource component/type executor/indexer executor/meta size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0