8000 fix: proper usage of importextensions by cristianmtr · Pull Request #2237 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: proper usage of importextensions #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2021
Merged

fix: proper usage of importextensions #2237

merged 1 commit into from
Mar 26, 2021

Conversation

cristianmtr
Copy link
Contributor

No description provided.

@cristianmtr cristianmtr requested a review from a team as a code owner March 25, 2021 14:26
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver labels Mar 25, 2021
@codecov
Copy link
codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #2237 (015a613) into master (2be26c6) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2237      +/-   ##
==========================================
+ Coverage   90.52%   90.61%   +0.09%     
==========================================
  Files         209      209              
  Lines       11282    11284       +2     
==========================================
+ Hits        10213    10225      +12     
+ Misses       1069     1059      -10
Flag Coverage Δ
daemon 51.17% <20.00%> (-0.01%) ⬇️
jina 91.08% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/debug.py 96.66% <100.00%> (+0.23%) ⬆️
jina/peapods/zmq/__init__.py 82.97% <0.00%> (+2.16%) ⬆️
jina/clients/base.py 82.64% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be26c6...015a613. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1053, delta to last 3 avg.: +2%
  • 🐢🐢 query QPS at 14, delta to last 3 avg.: -6%

Breakdown

Version Index QPS Query QPS
current 1053 14
1.0.15 1045 14
1.0.14 1008 15

Backed by latency-tracking. Further commits will update this comment.

nan-wang
nan-wang approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit f2def8a into master Mar 26, 2021
@nan-wang nan-wang deleted the fix-import-pngtodisk branch March 26, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@CatStark CatStark Awaiting requested review from CatStark

@Kelton8Z Kelton8Z Awaiting requested review from Kelton8Z

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristianmtr @nan-wang @jina-bot
0