8000 docs: fix fp1 typo in readme by robertjrodger · Pull Request #2188 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix fp1 typo in readme #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

robertjrodger
Copy link
Contributor

Two times in the README.md, a file is opened as fp and used as fp1. This PR corrects this.

@robertjrodger robertjrodger requested a review from a team as a code owner March 16, 2021 20:13
Copy link
Contributor
@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Thanks for contributing! ❤️

@codecov
Copy link
codecov bot commented Mar 16, 2021

Codecov Report

Merging #2188 (0478fd1) into master (3bf8c15) will decrease coverage by 3.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
- Coverage   90.41%   86.82%   -3.59%     
==========================================
  Files         208      208              
  Lines       11243    11243              
==========================================
- Hits        10165     9762     -403     
- Misses       1078     1481     +403     
Flag Coverage Δ
daemon 50.20% <ø> (ø)
jina 87.06% <ø> (-3.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/docker/hubapi/remote.py 20.27% <0.00%> (-70.28%) ⬇️
jina/docker/hubapi/local.py 18.39% <0.00%> (-70.12%) ⬇️
jina/jaml/parsers/flow/v1.py 48.14% <0.00%> (-44.45%) ⬇️
jina/clients/asyncio.py 50.00% <0.00%> (-40.63%) ⬇️
jina/docker/helper.py 66.66% <0.00%> (-33.34%) ⬇️
jina/docker/hubio.py 53.59% <0.00%> (-30.53%) ⬇️
jina/jaml/parsers/flow/legacy.py 22.72% <0.00%> (-20.46%) ⬇️
jina/flow/mixin/async_crud.py 44.59% <0.00%> (-14.87%) ⬇️
jina/docker/checker.py 83.33% <0.00%> (-14.82%) ⬇️
jina/flow/base.py 78.00% <0.00%> (-14.58%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf8c15...0478fd1. Read the comment docs.

@JoanFM
Copy link
Contributor
JoanFM commented Mar 16, 2021

recheckcla

@github-actions
Copy link
github-actions bot commented Mar 16, 2021

Jina CLA check ✅ All Contributors have signed the CLA.

@robertjrodger
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 854, delta to last 3 avg.: -9%
  • 🐢🐢 query QPS at 12, delta to last 3 avg.: -12%

Breakdown

Version Index QPS Query QPS
current 854 12
1.0.10 941 13
1.0.9 952 13

Backed by latency-tracking. Further commits will update this comment.

@jina-ai jina-ai locked and limited conversation to collaborators Mar 16, 2021
@hanxiao hanxiao merged commit f8ba303 into jina-ai:master Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0