8000 refactor: remove unused variable by florian-hoenicke · Pull Request #2171 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove unused variable #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner March 15, 2021 20:30
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/docker labels Mar 15, 2021
@github-actions
Copy link
github-actions bot commented Mar 15, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 976, delta to last 3 avg.: +0%
  • 😶 query QPS at 14, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 976 14
1.0.9 978 14
1.0.8 990 14

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Mar 15, 2021

Codecov Report

Merging #2171 (e7a90e5) into master (e80b383) will increase coverage by 1.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2171      +/-   ##
==========================================
+ Coverage   89.00%   90.46%   +1.45%     
==========================================
  Files         211      211              
  Lines       11269    11269              
==========================================
+ Hits        10030    10194     +164     
+ Misses       1239     1075     -164     
Flag Coverage Δ
daemon 50.24% <0.00%> (ø)
jina 90.91% <100.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/docker/hubio.py 84.11% <100.00%> (ø)
jina/helper.py 83.65% <0.00%> (+0.84%) ⬆️
jina/types/message/__init__.py 88.20% <0.00%> (+1.53%) ⬆️
jina/drivers/control.py 95.08% <0.00%> (+1.63%) ⬆️
jina/peapods/zmq/__init__.py 82.01% <0.00%> (+2.13%) ⬆️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (+2.18%) ⬆️
jina/drivers/convertdriver.py 97.22% <0.00%> (+2.77%) ⬆️
jina/flow/mixin/crud.py 89.65% <0.00%> (+3.44%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.48% <0.00%> (+3.54%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 95.91% <0.00%> (+4.08%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e80b383...e7a90e5. Read the comment docs.

@nan-wang nan-wang requested a review from deepankarm March 16, 2021 09:17
@florian-hoenicke florian-hoenicke merged commit ef155a3 into master Mar 16, 2021
@florian-hoenicke florian-hoenicke deleted the refactor-remove-unused-variable branch March 16, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/docker size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0