8000 docs(openapi): autogenerate curl commands with redoc by deepankarm · Pull Request #2130 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(openapi): autogenerate curl commands with redoc #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 9, 2021
Merged

docs(openapi): autogenerate curl commands with redoc #2130

merged 5 commits into from
Mar 9, 2021

Conversation

deepankarm
Copy link
Contributor
@deepankarm deepankarm commented Mar 9, 2021 •
edited
Loading

Fixes #2092
image

@deepankarm deepankarm requested review from hanxiao and a team as code owners March 9, 2021 05:14
@deepankarm deepankarm requested a review from Yongxuanzhang March 9, 2021 05:14
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/daemon area/housekeeping This issue/PR is housekeeping labels Mar 9, 2021
@github-actions
Copy link
github-actions bot commented Mar 9, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 965, delta to last 3 avg.: -3%
  • 😶 query QPS at 16, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 965 16
1.0.8 1019 16
1.0.7 988 16

Backed by latency-tracking. Further commits will update this comment.

@deepankarm
Copy link
Contributor Author

We should check for black/docstring only for added/modified files - #2131

@codecov
Copy link
codecov bot commented Mar 9, 2021 •
edited
Loading

Codecov Report

Merging #2130 (8e83fd2) into master (5129f58) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2130      +/-   ##
==========================================
- Coverage   90.37%   90.35%   -0.03%     
==========================================
  Files         211      211              
  Lines       11223    11217       -6     
==========================================
- Hits        10143    10135       -8     
- Misses       1080     1082       +2
Flag Coverage Δ
daemon 50.43% <ø> (-6.13%) ⬇️
jina 90.80% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daemon/__init__.py 60.86% <ø> (+5.10%) ⬆️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (-5.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5129f58...b7061e1. Read the comment docs.

nan-wang
nan-wang approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 06ebc5c into master Mar 9, 2021
@nan-wang nan-wang deleted the redoc-code-sample branch March 9, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code snippet with redoc api docs 3660
3 participants
@deepankarm @nan-wang @jina-bot
0