8000 feat(schema): add json schema generator by hanxiao · Pull Request #2059 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(schema): add json schema generator #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2021
Merged

feat(schema): add json schema generator #2059

merged 1 commit into from
Feb 27, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Feb 27, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 27, 2021 06:42
@hanxiao hanxiao requested review from nan-wang and JoanFM February 27, 2021 06:42
@jina-bot jina-bot added size/M area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing labels Feb 27, 2021
@codecov
Copy link
codecov bot commented Feb 27, 2021 •
edited
Loading

Codecov Report

Merging #2059 (fe8baa3) into master (dc0ef98) will increase coverage by 0.03%.
The diff coverage is 98.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
+ Coverage   89.20%   89.23%   +0.03%     
==========================================
  Files         200      208       +8     
  Lines       10928    11045     +117     
==========================================
+ Hits         9748     9856     +108     
- Misses       1180     1189       +9
Flag Coverage Δ
daemon 50.74% <58.97%> (+0.08%) ⬆️
jina 89.68% <98.29%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/schemas/helper.py 97.64% <97.64%> (ø)
jina/importer.py 97.14% <100.00%> (+0.06%) ⬆️
jina/parsers/export_api.py 87.50% <100.00%> (+1.78%) ⬆️
jina/schemas/__init__.py 100.00% <100.00%> (ø)
jina/schemas/driver.py 100.00% <100.00%> (ø)
jina/schemas/executor.py 100.00% <100.00%> (ø)
jina/schemas/flow.py 100.00% <100.00%> (ø)
jina/schemas/meta.py 100.00% <100.00%> (ø)
jina/schemas/pod.py 100.00% <100.00%> (ø)
jina/schemas/request.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3974da0...de3050c. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1280, delta to last 3 avg.: +0%
  • 😶 query QPS at 20, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1280 20
1.0.4 1281 20
1.0.3 1269 20

Backed by latency-tracking. Further commits will update this comment.

8BBC
@hanxiao hanxiao merged commit 7fcce50 into master Feb 27, 2021
@hanxiao hanxiao deleted the feat-json-schema branch February 27, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0