8000 refactor: remove unused encoder classes and interfaces by JoanFM · Pull Request #2031 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove unused encoder classes and interfaces #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2021
Merged

refactor: remove unused encoder classes and interfaces #2031

merged 1 commit into from
Feb 24, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Feb 24, 2021 •
edited
Loading

Changes introduced
Remove untested and unused interfaces or classes.

If someone wants to implement such functionality I think they should develop them in the hub

@JoanFM JoanFM requested a review from a team as a code owner February 24, 2021 09:24
@codecov
Copy link
codecov bot commented Feb 24, 2021 •
edited
Loading

Codecov Report

Merging #2031 (d04c416) into master (fb303b8) will increase coverage by 1.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
+ Coverage   87.33%   88.60%   +1.27%     
==========================================
  Files         202      200       -2     
  Lines       11022    10943      -79     
==========================================
+ Hits         9626     9696      +70     
+ Misses       1396     1247     -149
Flag Coverage Δ
daemon 50.43% <ø> (+0.08%) ⬆️
jina 89.02% <ø> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/zmq/__init__.py 80.06% <0.00%> (-2.15%) ⬇️
jina/clients/base.py 79.16% <0.00%> (-1.67%) ⬇️
jina/helper.py 85.20% <0.00%> (+0.22%) ⬆️
jina/executors/__init__.py 92.56% <0.00%> (+0.41%) ⬆️
jina/importer.py 80.42% <0.00%> (+0.85%) ⬆️
jina/jaml/parsers/executor/legacy.py 91.83% <0.00%> (+1.02%) ⬆️
jina/drivers/search.py 98.14% <0.00%> (+1.85%) ⬆️
jina/drivers/convertdriver.py 97.22% <0.00%> (+2.77%) ⬆️
daemon/stores/base.py 92.53% <0.00%> (+4.47%) ⬆️
jina/executors/decorators.py 91.27% <0.00%> (+6.39%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb303b8...daa2029. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1026, delta to last 3 avg.: +0%
  • 😶 query QPS at 17, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1026 17
1.0.4 1025 16
1.0.3 1014 16

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 810d71a into master Feb 24, 2021
@hanxiao hanxiao deleted the remove-client-executors branch February 24, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@davidbp davidbp Awaiting requested review from davidbp

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/executor executor/encoder executor/meta size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @hanxiao @jina-bot
0