8000 fix: improve unittesting of score by JoanFM · Pull Request #2029 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: improve unittesting of score #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2021
Merged

fix: improve unittesting of score #2029

merged 3 commits into from
Feb 25, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Feb 24, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner February 24, 2021 08:54
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Feb 24, 2021
@codecov
Copy link
codecov bot commented Feb 24, 2021 •
edited
Loading

Codecov Report

Merging #2029 (2a2d9ba) into master (fb303b8) will increase coverage by 1.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
+ Coverage   87.33%   88.75%   +1.42%     
==========================================
  Files         202      200       -2     
  Lines       11022    10947      -75     
==========================================
+ Hits         9626     9716      +90     
+ Misses       1396     1231     -165
Flag Coverage Δ
daemon 50.45% <30.76%> (+0.09%) ⬆️
jina 89.18% <100.00%> (+1.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/encoders/__init__.py 90.00% <ø> (+30.00%) ⬆️
jina/peapods/peas/helper.py 97.87% <ø> (ø)
jina/peapods/runtimes/asyncio/base.py 87.50% <ø> (ø)
jina/peapods/runtimes/asyncio/grpc/__init__.py 100.00% <ø> (ø)
jina/peapods/runtimes/asyncio/rest/__init__.py 96.42% <ø> (ø)
jina/peapods/runtimes/asyncio/rest/app.py 77.69% <ø> (ø)
jina/peapods/runtimes/asyncio/rest/models.py 100.00% <ø> (ø)
jina/peapods/runtimes/container/__init__.py 92.70% <ø> (ø)
jina/peapods/runtimes/jinad/__init__.py 95.91% <ø> (ø)
jina/peapods/runtimes/jinad/client.py 82.48% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb303b8...04ab088. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 24, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 968, delta to last 3 avg.: +1%
  • 😶 query QPS at 14, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 968 14
1.0.4 978 14
1.0.3 937 13

Backed by latency-tracking. Further commits will update this comment.

CatStark
CatStark previously approved these changes Feb 24, 2021
View reviewed changes
JoanFM
JoanFM commented Feb 24, 2021
View reviewed changes
@hanxiao hanxiao merged commit 18bde58 into master Feb 25, 2021
@hanxiao hanxiao deleted the test-improve-score branch February 25, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@CatStark CatStark CatStark left review comments

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanFM @hanxiao @CatStark @jina-bot
0