8000 refactor(types): remove legacy and unused traverse function by hanxiao · Pull Request #2017 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(types): remove legacy and unused traverse function #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2021
Merged

refactor(types): remove legacy and unused traverse function #2017

merged 1 commit into from
Feb 23, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Feb 23, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 23, 2021 06:06
@hanxiao hanxiao requested review from CatStark and JoanFM February 23, 2021 06:06
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Feb 23, 2021
@codecov
Copy link
codecov bot commented Feb 23, 2021 •
edited
Loading

Codecov Report

Merging #2017 (9fe9a8d) into master (41a5efd) will decrease coverage by 14.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2017       +/-   ##
===========================================
- Coverage   88.02%   73.56%   -14.46%     
===========================================
  Files         183      183               
  Lines       10468    10455       -13     
===========================================
- Hits         9214     7691     -1523     
- Misses       1254     2764     +1510
Flag Coverage Δ
jina 73.56% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/document/__init__.py 71.73% <100.00%> (-16.67%) ⬇️
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/optimizer.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-97.50%) ⬇️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a5efd...bd8b1c2. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1087, delta to last 3 avg.: +0%
  • 😶 query QPS at 18, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1087 18
1.0.4 1095 18
1.0.3 1088 18

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 12892b2 into master Feb 23, 2021
@hanxiao hanxiao deleted the rm-unused-function branch February 23, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatStark CatStark Awaiting requested review from CatStark

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0