8000 feat(demo): add multimodal hello-world by hanxiao · Pull Request #2002 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(demo): add multimodal hello-world #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2021
Merged

feat(demo): add multimodal hello-world #2002

merged 4 commits into from
Feb 21, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Feb 21, 2021 •
edited
Loading

@hanxiao hanxiao requested a review from a team as a code owner February 21, 2021 05:38
@jina-bot jina-bot added size/L area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/resource labels Feb 21, 2021
@codecov
Copy link
codecov bot commented Feb 21, 2021 •
edited
Loading

Codecov Report

Merging #2002 (5249ef2) into master (5797167) will decrease coverage by 1.57%.
The diff coverage is 86.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2002      +/-   ##
==========================================
- Coverage   86.53%   84.96%   -1.58%     
==========================================
  Files         148      165      +17     
  Lines        7084     7621     +537     
==========================================
+ Hits         6130     6475     +345     
- Misses        954     1146     +192
Flag Coverage Δ
daemon 45.96% <6.12%> (?)
jina 85.05% <86.56%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/clients.py 33.33% <ø> (ø)
jina/executors/compound.py 89.31% <ø> (ø)
jina/executors/crafters/__init__.py 92.85% <ø> (-7.15%) ⬇️
jina/executors/devices.py 56.86% <ø> (ø)
jina/executors/encoders/numeric/__init__.py 42.42% <ø> (ø)
jina/executors/encoders/tfserving.py 63.15% <ø> (ø)
jina/executors/evaluators/running_stats.py 96.00% <ø> (ø)
jina/executors/indexers/keyvalue.py 98.70% <ø> (ø)
jina/executors/indexers/vector.py 94.44% <ø> (ø)
jina/executors/rankers/__init__.py 93.02% <ø> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071b7cd...5249ef2. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 21, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1152, delta to last 3 avg.: +1%
  • 🐢🐢 query QPS at 18, delta to last 3 avg.: -6%

Breakdown

Version Index QPS Query QPS
current 1152 18
1.0.2 1132 19
1.0.1 1143 19

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit b8fdb1a into master Feb 21, 2021
@hanxiao hanxiao deleted the feat-add-multimodal-hw branch February 21, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@imsergiy imsergiy Awaiting requested review from imsergiy

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/resource size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0