test(logging): add profiling test #2000
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2000 +/- ##
===========================================
- Coverage 86.53% 68.17% -18.36%
===========================================
Files 148 151 +3
Lines 7084 7146 +62
===========================================
- Hits 6130 4872 -1258
- Misses 954 2274 +1320
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
tests/unit/logging/test_profile.py
Outdated
| def foo(): | ||
| print(1) | ||
| foo() | ||
| assert "memory" in caplog.text |
tests/unit/logging/test_profile.py
Outdated
| def test_logging_profile_profiling(caplog, default_logger_propagate): | ||
| @profiling | ||
| def foo(): | ||
| print(1) |
There was a problem hiding this comment.
we could allocate some memory here or sleep for some time to showcase how it is used and how the memory and some time is returned.
Tests tend to be good way to clarify behavior
There was a problem hiding this comment.
Sure! I add some changes. Not sure if this is ok
|
for some reason, merging this PR breaks the |
No description provided.