8000 fix: apply changes for daemon codecov to cd by JoanFM · Pull Request #1996 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: apply changes for daemon codecov to cd #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2021
Merged

fix: apply changes for daemon codecov to cd #1996

merged 2 commits into from
Feb 24, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Feb 20, 2021 •
edited
Loading

Changes introduced
Apply the same changes to CD as the ones CI

Nice TODO in the future

  • Modularize our github actions

@JoanFM JoanFM requested a review from hanxiao as a code owner February 20, 2021 16:10
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Feb 20, 2021
@codecov
Copy link
codecov bot commented Feb 20, 2021 •
edited
Loading

Codecov Report

Merging #1996 (42909ab) into master (110a0f1) will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1996      +/-   ##
==========================================
+ Coverage   84.03%   84.55%   +0.52%     
==========================================
  Files         149      161      +12     
  Lines        7120     7577     +457     
==========================================
+ Hits         5983     6407     +424     
- Misses       1137     1170      +33
Flag Coverage Δ
daemon 46.33% <ø> (?)
jina 84.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helloworld/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/components.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/multimodal/__init__.py 0.00% <0.00%> (-90.91%) ⬇️
jina/helloworld/helper.py 0.00% <0.00%> (-90.63%) ⬇️
jina/helloworld/chatbot/__init__.py 0.00% <0.00%> (-89.29%) ⬇️
jina/executors/devices.py 50.98% <0.00%> (-5.89%) ⬇️
jina/drivers/convertdriver.py 88.88% <0.00%> (-5.56%) ⬇️
jina/parsers/helloworld.py 92.98% <0.00%> (-5.27%) ⬇️
jina/logging/profile.py 82.67% <0.00%> (-3.15%) ⬇️
jina/parsers/helper.py 48.66% <0.00%> (-2.00%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110a0f1...58d24e6. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 20, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1118, delta to last 3 avg.: +3%
  • 😶 query QPS at 18, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1118 18
1.0.4 1085 17
1.0.3 1082 18

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM closed this Feb 22, 2021
@JoanFM JoanFM reopened this Feb 22, 2021
@nan-wang
Copy link
Member

Can you confirm daemon is covered by codecov? https://app.codecov.io/gh/jina-ai/jina

@JoanFM
Copy link
Contributor Author
JoanFM commented Feb 24, 2021

Can you confirm daemon is covered by codecov? https://app.codecov.io/gh/jina-ai/jina

Hey Nan, I cannot, I just see that in the comments for every PR it shows difference between jina and daemon. But not in the main codecov, I wonder if this is because we do not have it in the CD.

But I honestly do not know

@nan-wang nan-wang merged commit 1caa7e6 into master Feb 24, 2021
@nan-wang nan-wang deleted the cd-daemon-codecov branch February 24, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @nan-wang @jina-bot
0