8000 fix(rest): openapi rendering for crud by deepankarm · Pull Request #1994 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(rest): openapi rendering for crud #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2021
Merged

fix(rest): openapi rendering for crud #1994

merged 2 commits into from
Feb 22, 2021

Conversation

deepankarm
Copy link
Contributor
@deepankarm deepankarm commented Feb 20, 2021 •
edited
Loading

Fixes #1956

@deepankarm deepankarm requested a review from a team as a code owner February 20, 2021 11:28
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Feb 20, 2021
@codecov
Copy link
codecov bot commented Feb 20, 2021 •
edited
Loading

Codecov Report

Merging #1994 (a0423de) into master (81c4e80) will decrease coverage by 5.32%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1994      +/-   ##
==========================================
- Coverage   86.61%   81.29%   -5.33%     
==========================================
  Files         148      165      +17     
  Lines        7084     7623     +539     
==========================================
+ Hits         6136     6197      +61     
- Misses        948     1426     +478
Flag Coverage Δ
daemon 45.95% <4.54%> (?)
jina 81.14% <89.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/clients.py 33.33% <ø> (ø)
jina/executors/compound.py 89.31% <ø> (ø)
jina/executors/crafters/__init__.py 92.85% <ø> (-7.15%) ⬇️
jina/executors/devices.py 56.86% <ø> (ø)
jina/executors/encoders/numeric/__init__.py 42.42% <ø> (ø)
jina/executors/encoders/tfserving.py 63.15% <ø> (ø)
jina/executors/evaluators/running_stats.py 96.00% <ø> (ø)
jina/executors/indexers/keyvalue.py 98.70% <ø> (ø)
jina/executors/indexers/vector.py 94.44% <ø> (ø)
jina/executors/rankers/__init__.py 93.02% <ø> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c4e80...4e7df6e. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1290, delta to last 3 avg.: +0%
  • 😶 query QPS at 20, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1290 20
1.0.2 1277 20
1.0.1 1293 20

Backed by latency-tracking. Further commits will update this comment.

hanxiao
hanxiao reviewed Feb 20, 2021
View reviewed changes
jina/peapods/runtimes/asyncio/rest/models.py Outdated
# To avoid an error while loading the request model schema on swagger, we've added an example.
data: Union[List[JinaDocumentModel], List[Dict[str, Any]], List[str], List[bytes]] = \
Field(..., example=[Document().dict()])
request_size: Optional[int] = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be 1, otherwise the REST interface will be unbelievable slow.

use set_client_parser().parser([]).request_size to get default request size

hanxiao
hanxiao requested changes Feb 20, 2021
View reviewed changes
Copy link
Member
@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request_size should not be 1

@hanxiao hanxiao merged commit de1de17 into master Feb 22, 2021
@hanxiao hanxiao deleted the fix-openapi-gateway branch February 22, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

@rutujasurve94 rutujasurve94 Awaiting requested review from rutujasurve94

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

not able use jina swager page, for indexing or searching
3 participants
@deepankarm @hanxiao @jina-bot
0