8000 fix: mixin should not be inherited from BaseDriver by JoanFM · Pull Request #1980 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: mixin should not be inherited from BaseDriver #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2021
Merged

fix: mixin should not be inherited from BaseDriver #1980

merged 2 commits into from
Feb 20, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Feb 19, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner February 19, 2021 07:30
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/driver labels Feb 19, 2021
@codecov
Copy link
codecov bot commented Feb 19, 2021 •
edited
Loading

Codecov Report

Merging #1980 (0eaf146) into master (97b6637) will increase coverage by 1.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
+ Coverage   81.22%   82.97%   +1.75%     
==========================================
  Files         148      148              
  Lines        7072     7072              
==========================================
+ Hits         5744     5868     +124     
+ Misses       1328     1204     -124
Impacted Files Coverage Δ
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/check.py 0.00% <0.00%> (-85.72%) ⬇️
jina/parsers/logger.py 0.00% <0.00%> (-85.72%) ⬇️
jina/parsers/export_api.py 0.00% <0.00%> (-85.72%) ⬇️
jina/clients/helper.py 59.09% <0.00%> (-36.37%) ⬇️
jina/parsers/hub/__init__.py 65.00% <0.00%> (-30.00%) ⬇️
jina/importer.py 53.61% <0.00%> (-25.54%) ⬇️
jina/types/ndarray/dense/numpy.py 84.21% <0.00%> (-15.79%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 79.16% <0.00%> (-12.50%) ⬇️
jina/peapods/runtimes/jinad/client.py 72.26% <0.00%> (-8.03%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b6637...a53155d. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 19, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 960, delta to last 3 avg.: +1%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -10%

Breakdown

Version Index QPS Query QPS
current 960 13
1.0.1 952 13
1.0.0 931 15

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM closed this Feb 19, 2021
@JoanFM JoanFM reopened this Feb 19, 2021
@hanxiao hanxiao merged commit a93a6cf into master Feb 20, 2021
@hanxiao hanxiao deleted the fix-mixin branch February 20, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@imsergiy imsergiy Awaiting requested review from imsergiy

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/driver size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @hanxiao @jina-bot
0