8000 ci: do not lint docstrings in tests by cristianmtr · Pull Request #1962 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: do not lint docstrings in tests #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2021
Merged

ci: do not lint docstrings in tests #1962

merged 1 commit into from
Feb 17, 2021

Conversation

cristianmtr
Copy link
Contributor

No description provided.

@cristianmtr cristianmtr requested a review from a team as a code owner February 17, 2021 11:39
CatStark
CatStark approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor
@CatStark CatStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@codecov
Copy link
codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #1962 (07882e0) into master (9a844b6) will increase coverage by 1.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
+ Coverage   84.71%   86.58%   +1.86%     
==========================================
  Files         148      148              
  Lines        7094     7094              
==========================================
+ Hits         6010     6142     +132     
+ Misses       1084      952     -132
Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (-1.46%) ⬇️
jina/drivers/control.py 95.08% <0.00%> (+1.63%) ⬆️
jina/clients/base.py 80.83% <0.00%> (+1.66%) ⬆️
jina/drivers/convertdriver.py 93.93% <0.00%> (+3.03%) ⬆️
jina/flow/mixin/crud.py 89.28% <0.00%> (+3.57%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.42% <0.00%> (+3.57%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 95.83% <0.00%> (+4.16%) ⬆️
jina/clients/helper.py 100.00% <0.00%> (+4.54%) ⬆️
jina/jaml/helper.py 93.89% <0.00%> (+6.87%) ⬆️
jina/executors/crafters/__init__.py 100.00% <0.00%> (+7.14%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a844b6...5994799. Read the comment docs.
8000

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 955, delta to last 3 avg.: +1%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -11%

Breakdown

Version Index QPS Query QPS
current 955 13
1.0.1 945 13
1.0.0 938 15

Backed by latency-tracking. Further commits will update this comment.

maximilianwerk
maximilianwerk approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bwanglzu
bwanglzu approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cristianmtr cristianmtr merged commit 89cf0bc into master Feb 17, 2021
@cristianmtr cristianmtr deleted the ci-docstrings-test branch February 17, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatStark CatStark CatStark approved these changes

@maximilianwerk maximilianwerk maximilianwerk approved these changes

@bwanglzu bwanglzu bwanglzu approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

@imsergiy imsergiy Awaiting requested review from imsergiy

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cristianmtr @CatStark @maximilianwerk @bwanglzu @jina-bot
0