8000 docs(jaml): add missing docstrings by Yongxuanzhang · Pull Request #1968 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(jaml): add missing docstrings #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2021
Merged

docs(jaml): add missing docstrings #1968

merged 4 commits into from
Feb 22, 2021

Conversation

Yongxuanzhang
Copy link
Contributor

No description provided.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/jaml labels Feb 18, 2021
@codecov
Copy link
codecov bot commented Feb 18, 2021 •
edited
Loading

Codecov Report

Merging #1968 (6bfb483) into master (f2046fa) will increase coverage by 0.52%.
The diff coverage is 92.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
+ Coverage   86.58%   87.10%   +0.52%     
==========================================
  Files         148      163      +15     
  Lines        7094     7595     +501     
==========================================
+ Hits         6142     6616     +474     
- Misses        952      979      +27
Flag Coverage Δ
daemon 46.16% <25.00%> (?)
jina 87.38% <92.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/index.py 96.15% <ø> (ø)
jina/enums.py 95.83% <ø> (-0.12%) ⬇️
jina/executors/clients.py 33.33% <ø> (ø)
jina/executors/compound.py 89.31% <ø> (ø)
jina/executors/crafters/__init__.py 100.00% <ø> (ø)
jina/executors/devices.py 56.86% <ø> (ø)
jina/executors/encoders/numeric/__init__.py 42.42% <ø> (ø)
jina/executors/encoders/tfserving.py 63.15% <ø> (ø)
jina/executors/evaluators/running_stats.py 96.00% <ø> (ø)
jina/executors/indexers/keyvalue.py 98.70% <ø> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2046fa...0bbfc08. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 18, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1072, delta to last 3 avg.: +0%
  • 😶 query QPS at 17, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1072 17
1.0.4 1067 17
1.0.3 1069 17

Backed by latency-tracking. Further commits will update this comment.

@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review February 18, 2021 02:58
@Yongxuanzhang Yongxuanzhang requested a review from a team as a code owner February 18, 2021 02:58
CatStark
CatStark previously approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor
@CatStark CatStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yongxuanzhang Yongxuanzhang requested review from florian-hoenicke and a team February 18, 2021 15:23
JoanFM
JoanFM previously requested changes Feb 18, 2021
View reviewed changes
Copy link
Contributor
@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the questions I asked? You can add prints and load yamls of different objects to see if they are called for different objects

10000

@Yongxuanzhang Yongxuanzhang requested a review from JoanFM February 19, 2021 01:33
CatStark
CatStark reviewed Feb 19, 2021
View reviewed changes
CatStark
CatStark suggested changes Feb 19, 2021
View reviewed changes
Copy link
Contributor
@CatStark CatStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more info to parameteres

CatStark
CatStark approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor
@CatStark CatStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@Yongxuanzhang Yongxuanzhang merged commit e133c05 into master Feb 22, 2021
@Yongxuanzhang Yongxuanzhang deleted the docs-update-jaml branch February 22, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatStark CatStark CatStark approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/jaml size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yongxuanzhang @CatStark @JoanFM @jina-bot
0