feat: ranking evaluate driver may need more than one field #1953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1953 +/- ##
==========================================
+ Coverage 84.71% 86.60% +1.88%
==========================================
Files 148 148
Lines 7094 7106 +12
==========================================
+ Hits 6010 6154 +144
+ Misses 1084 952 -132
Continue to review full report at Codecov.
|
9b84d34 to
a86e78c
Compare
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
nan-wang
requested changes
Feb 16, 2021
…luate-multiple-fields
2dcbb8e to
4508080
Compare
…luate-multiple-fields
9f5af3f to
915fdc0
Compare
bwanglzu
reviewed
Feb 17, 2021
…luate-multiple-fields
deepankarm
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced
Motivation of this PR comes from the realization that
NDCGEvaluatoris not applicable, since more than one field may be needed for it.RankingEvaluateDrivernow can access multiple fields of thematchesof bothDocumentandGroundTruth.For instance, for NDCGEvaluator, we may need:
fields = ('tags__id', 'score__value')
So that the NDCGEvaluator would get
desired = (id, relevance), (id, relevance)
actual = (id, score), (id, score) so that it can be properly computed