8000 refactor(driver): use traverse from document type by hanxiao · Pull Request #1938 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(driver): use traverse from document type #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 13, 2021
Merged

refactor(driver): use traverse from document type #1938

merged 6 commits into from
Feb 13, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Feb 12, 2021 •
edited
Loading

this is the continuation of #1937 to solve #1932

I've already layout the new implementation of RecursiveDriver, please continue on

  • refactoring all drivers using this new logic
  • retiring & refactoring test

@hanxiao hanxiao added the priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. label Feb 12, 2021
@github-actions
Copy link

This PR closes: #1932

@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase component/driver labels Feb 12, 2021
@codecov
Copy link
codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #1938 (1a4e419) into master (9d1d59e) will decrease coverage by 5.98%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1938      +/-   ##
==========================================
- Coverage   86.57%   80.59%   -5.99%     
==========================================
  Files         148      148              
  Lines        7067     7079      +12     
==========================================
- Hits         6118     5705     -413     
- Misses        949     1374     +425
Impacted Files Coverage Δ
jina/drivers/encode.py 91.30% <93.33%> (-5.25%) ⬇️
jina/drivers/index.py 96.15% <100.00%> (-0.15%) ⬇️
jina/drivers/predict.py 92.59% <100.00%> (ø)
jina/drivers/search.py 98.14% <100.00%> (ø)
jina/types/sets/document.py 75.38% <100.00%> (-21.50%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/executors/evaluators/embedding/cosine.py 36.66% <0.00%> (-56.67%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1d59e...1a4e419. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 12, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1160, delta to last 3 avg.: +1%
  • 🐢🐢 query QPS at 19, delta to last 3 avg.: -12%

Breakdown

Version Index QPS Query QPS
current 1160 19
1.0.0 1129 21
0.9.33 1145 21

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao mentioned this pull request Feb 13, 2021
Closed
@jina-bot jina-bot added area/testing This issue/PR affects testing component/type labels Feb 13, 2021
@hanxiao hanxiao marked this pull request as ready for review February 13, 2021 19:03
@hanxiao hanxiao requested a review from a team as a code owner February 13, 2021 19:03
@hanxiao hanxiao merged commit d83d188 into master Feb 13, 2021
@hanxiao hanxiao deleted the fix-part2-1932 branch February 13, 2021 19:03
@nan-wang
Copy link
Member
nan-wang commented Feb 14, 2021 •
edited
Loading

The returning type of traverse() in DocumentSet is changed in this PR. As DocumentSet is a part of the main public APIs, this makes this PR a potential breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roshanjossey Roshanjossey Awaiting requested review from Roshanjossey

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/type priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanxiao @nan-wang @jina-bot
0