8000 docs: docstrings for flow module by cristianmtr · Pull Request #1922 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: docstrings for flow module #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2021
Merged

docs: docstrings for flow module #1922

merged 3 commits into from
Feb 10, 2021

Conversation

cristianmtr
Copy link
Contributor

No description provided.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/flow labels Feb 10, 2021
@codecov
Copy link
codecov bot commented Feb 10, 2021 •
edited
Loading

Codecov Report

Merging #1922 (cf297b3) into master (fb3d1db) will decrease coverage by 18.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1922       +/-   ##
===========================================
- Coverage   86.50%   67.76%   -18.75%     
===========================================
  Files         148      148               
  Lines        7042     7042               
===========================================
- Hits         6092     4772     -1320     
- Misses        950     2270     +1320
Impacted Files Coverage Δ
jina/flow/asyncio.py 87.50% <ø> (ø)
jina/flow/builder.py 73.91% <ø> (ø)
jina/flow/mixin/async_crud.py 59.45% <ø> (ø)
jina/flow/mixin/crud.py 71.42% <ø> (-17.86%) ⬇️
jina/flow/base.py 87.50% <100.00%> (-2.35%) ⬇️
jina/docker/helper.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb3d1db...cf297b3. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 10, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1046, delta to last 3 avg.: +0%
  • 😶 query QPS at 19, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1046 19
1.0.0 1062 19
0.9.33 1046 20

Backed by latency-tracking. Further commits will update this comment.

@cristianmtr cristianmtr marked this pull request as ready for review February 10, 2021 10:16
@cristianmtr cristianmtr requested a review from a team as a code owner February 10, 2021 10:16
@jina-bot jina-bot added size/M and removed size/S labels Feb 10, 2021
alexcg1
alexcg1 requested changes Feb 10, 2021
View reviewed changes
Copy link
Member
@alexcg1 alexcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine generally. Just check capitalization of Pods, Flows, Peas throughout (I've commented initially but don't have time to go through each one - there are a few tho)

@cristianmtr cristianmtr requested a review from alexcg1 February 10, 2021 12:07
@cristianmtr cristianmtr force-pushed the docs-docstrings-flow branch 3 times, most recently from 0998bed to 6fe6e18 Compare February 10, 2021 12:37
alexcg1
alexcg1 requested changes Feb 10, 2021
View reviewed changes
@cristianmtr cristianmtr requested a review from alexcg1 February 10, 2021 14:29
@cristianmtr
Copy link
Contributor Author

Looks fine generally. Just check capitalization of Pods, Flows, Peas throughout (I've commented initially but don't have time to go through each one - there are a few tho)

Check again

8000
@hanxiao hanxiao merged commit 009d40c into master Feb 10, 2021
@hanxiao hanxiao deleted the docs-docstrings-flow branch February 10, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rutujasurve94 rutujasurve94 Awaiting requested review from rutujasurve94

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@CatStark CatStark Awaiting requested review from CatStark

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

@alexcg1 alexcg1 Awaiting requested review from alexcg1

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/flow size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristianmtr @alexcg1 @hanxiao @jina-bot
0