8000 docs(ndarray): update docstring for ndarray by Yongxuanzhang · Pull Request #1920 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(ndarray): update docstring for ndarray #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2021
Merged

docs(ndarray): update docstring for ndarray #1920

merged 2 commits into from
Feb 10, 2021

Conversation

Yongxuanzhang
Copy link
Contributor

Mainly reformatted to fit the docstring guide.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/type labels Feb 10, 2021
@codecov
Copy link
codecov bot commented Feb 10, 2021 •
edited
Loading

Codecov Report

Merging #1920 (f2c7190) into master (70b9bc9) will decrease coverage by 1.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
- Coverage   84.15%   82.37%   -1.78%     
==========================================
  Files         148      148              
  Lines        7042     7042              
==========================================
- Hits         5926     5801     -125     
- Misses       1116     1241     +125
Impacted Files Coverage Δ
jina/types/ndarray/sparse/__init__.py 93.33% <ø> (ø)
jina/types/ndarray/sparse/numpy.py 100.00% <ø> (ø)
jina/types/ndarray/sparse/pytorch.py 100.00% <ø> (ø)
jina/types/ndarray/sparse/scipy.py 90.00% <ø> (ø)
jina/types/ndarray/sparse/tensorflow.py 100.00% <ø> (ø)
jina/types/ndarray/dense/numpy.py 84.21% <100.00%> (-15.79%) ⬇️
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/clients/request/asyncio.py 0.00% <0.00%> (-89.48%) ⬇️
jina/parsers/check.py 0.00% <0.00%> (-85.72%) ⬇️
jina/parsers/logger.py 0.00% <0.00%> (-85.72%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b72120...f2c7190. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 10, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1043, delta to last 3 avg.: +1%
  • 😶 query QPS at 20, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1043 20
0.9.33 1030 20

Backed by latency-tracking. Further commits will update this comment.

@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review February 10, 2021 04:41
8000
@Yongxuanzhang Yongxuanzhang requested a review from a team as a code owner February 10, 2021 04:41
nan-wang
nan-wang approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 5fb7ea8 into master Feb 10, 2021
@nan-wang nan-wang deleted the docs-update-types-ndarrya branch February 10, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@deepankarm deepankarm Awaiting requested review from deepankarm

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yongxuanzhang @nan-wang @jina-bot
0