8000 feat(types): add update method to document types by hanxiao · Pull Request #1926 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(types): add update method to document types #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 10, 2021
Merged

feat(types): add update method to document types #1926

merged 8 commits into from
Feb 10, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Feb 10, 2021

this solves #1891

@hanxiao hanxiao requested a review from a team as a code owner February 10, 2021 19:04
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/type labels Feb 10, 2021
@hanxiao hanxiao linked an issue Feb 10, 2021 that may be closed by this pull request
Problems with shape and repeated fields under MergeFrom (is_merge option in KVSearchDriver) #1891
Closed
@codecov
Copy link
codecov bot commented Feb 10, 2021 •
edited
Loading

Codecov Report

Merging #1926 (1df90cc) into master (fb3d1db) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1926      +/-   ##
==========================================
- Coverage   86.50%   86.26%   -0.25%     
==========================================
  Files         148      148              
  Lines        7042     7042              
==========================================
- Hits         6092     6075      -17     
- Misses        950      967      +17
Impacted Files Coverage Δ
jina/flow/asyncio.py 87.50% <ø> (ø)
jina/flow/builder.py 73.91% <ø> (ø)
jina/flow/mixin/async_crud.py 59.45% <ø> (ø)
jina/flow/mixin/crud.py 89.28% <ø> (ø)
jina/drivers/search.py 96.42% <100.00%> (ø)
jina/flow/base.py 89.84% <100.00%> (ø)
jina/peapods/runtimes/jinad/__init__.py 83.33% <0.00%> (-12.50%) ⬇️
jina/peapods/runtimes/jinad/client.py 74.45% <0.00%> (-8.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305804b...607bfc8. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 10, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1013, delta to last 3 avg.: -2%
  • 😶 query QPS at 19, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1013 19
1.0.0 1016 19
0.9.33 1051 19

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Feb 10, 2021
@hanxiao hanxiao merged commit deff987 into master Feb 10, 2021
@hanxiao hanxiao deleted the refactor-update-doc branch February 10, 2021 21:54
@nan-wang
Copy link
Member

This is a potential Breaking change because the API of KVSearchDriver is changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/driver component/resource component/type size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with shape and repeated fields under MergeFrom (is_merge option in KVSearchDriver)
3 participants
@hanxiao @nan-wang @jina-bot
0