8000 fix(resources): fix yaml config in resources by hanxiao · Pull Request #1913 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(resources): fix yaml config in resources #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2021
Merged

fix(resources): fix yaml config in resources #1913

merged 3 commits into from
Feb 9, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Feb 9, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 9, 2021 14:52
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/resource labels Feb 9, 2021
@codecov
Copy link
codecov bot commented Feb 9, 2021 •
edited
Loading

Codecov Report

Merging #1913 (22030db) into master (a60135f) will decrease coverage by 13.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1913       +/-   ##
===========================================
- Coverage   84.15%   71.12%   -13.03%     
===========================================
  Files         148      148               
  Lines        7043     7041        -2     
===========================================
- Hits         5927     5008      -919     
- Misses       1116     2033      +917
Impacted Files Coverage Δ
jina/drivers/control.py 95.08% <ø> (ø)
jina/drivers/convert.py 88.88% <ø> (-7.41%) ⬇️
jina/drivers/encode.py 61.66% <ø> (-33.34%) ⬇️
jina/drivers/evaluate.py 56.89% <ø> (-39.66%) ⬇️
jina/drivers/multimodal.py 36.11% <ø> (-55.56%) ⬇️
jina/peapods/runtimes/asyncio/rest/app.py 69.06% <ø> (-8.64%) ⬇️
jina/types/sets/chunk.py 91.66% <ø> (ø)
jina/types/sets/document.py 57.01% <ø> (-38.60%) ⬇️
jina/types/sets/match.py 95.83% <ø> (ø)
jina/types/sets/querylang.py 41.93% <ø> (-51.62%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60135f...89ba57f. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 9, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1247, delta to last 3 avg.: -2%
  • 😶 query QPS at 24, delta to last 3 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 1247 24
0.9.33 8000 1274 23

Backed by latency-tracking. Further commits will update this comment.

Yongxuanzhang
Yongxuanzhang reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor
@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/unit/test_driver_yaml.py::test_resource_executor is failing since executors._route.yml, executors._unique.yml, executors._unique_content.yml are removed. Shall we also remove the corresponding tests?

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Feb 9, 2021
@hanxiao hanxiao merged commit 573d67b into master Feb 9, 2021
@hanxiao hanxiao deleted the fix-resources-yaml branch February 9, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@nan-wang nan-wang Awaiting requested review from nan-wang

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/resource size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanxiao @Yongxuanzhang @jina-bot
0