8000 docs(types): update docstring for request by Yongxuanzhang · Pull Request #1919 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(types): update docstring for request #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

docs(types): update docstring for request #1919

merged 1 commit into from
Feb 10, 2021

Conversation

Yongxuanzhang
Copy link
Contributor

No description provided.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/type labels Feb 10, 2021
@codecov
Copy link
codecov bot commented Feb 10, 2021 •
edited
Loading

Codecov Report

Merging #1919 (64427d3) into master (70b9bc9) will increase coverage by 2.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
+ Coverage   84.15%   86.50%   +2.35%     
==========================================
  Files         148      148              
  Lines        7042     7042              
==========================================
+ Hits         5926     6092     +166     
+ Misses       1116      950     -166
Impacted Files Coverage Δ
jina/types/request/common.py 100.00% <ø> (ø)
jina/flow/base.py 89.84% <0.00%> (+0.78%) ⬆️
jina/drivers/evaluate.py 98.27% <0.00%> (+1.72%) ⬆️
jina/logging/profile.py 70.86% <0.00%> (+3.14%) ⬆️
jina/drivers/convert.py 100.00% <0.00%> (+3.70%) ⬆️
jina/parsers/helloworld.py 100.00% <0.00%> (+5.00%) ⬆️
jina/executors/devices.py 56.86% <0.00%> (+5.88%) ⬆️
jina/helloworld/chatbot/__init__.py 89.28% <0.00%> (+89.28%) ⬆️
jina/helloworld/helper.py 90.62% <0.00%> (+90.62%) ⬆️
jina/helloworld/__init__.py 100.00% <0.00%> (+100.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b9bc9...6afcc3d. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1056, delta to last 3 avg.: +0%
  • 😶 query QPS at 19, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1056 19
0.9.33 1061 19

Backed by latency-tracking. Further commits will update this comment.

@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review February 10, 2021 04:41
@Yongxuanzhang Yongxuanzhang requested a review from a team as a code owner February 10, 2021 04:41
nan-wang
nan-wang approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 768c9a8 into master Feb 10, 2021
@nan-wang nan-wang deleted the docs-update-types-request branch February 10, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@CatStark CatStark Awaiting requested review from CatStark

@imsergiy imsergiy Awaiting requested review from imsergiy

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yongxuanzhang @nan-wang @jina-bot
0