8000 docs: improve docstrings on drivers by cristianmtr · Pull Request #1914 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: improve docstrings on drivers #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2021
Merged

docs: improve docstrings on drivers #1914

merged 1 commit into from
Feb 9, 2021

Conversation

cristianmtr
Copy link
Contributor

No description provided.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/driver labels Feb 9, 2021
JoanFM
JoanFM previously requested changes Feb 9, 2021
View reviewed changes
@codecov
Copy link
codecov bot commented Feb 9, 2021 •
edited
Loading

Codecov Report

Merging #1914 (f874975) into master (fe7222b) will increase coverage by 1.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1914      +/-   ##
==========================================
+ Coverage   84.53%   86.50%   +1.97%     
==========================================
  Files         148      148              
  Lines        7041     7041              
==========================================
+ Hits         5952     6091     +139     
+ Misses       1089      950     -139
Impacted Files Coverage Δ
jina/drivers/control.py 95.08% <ø> (+1.63%) ⬆️
jina/drivers/convert.py 100.00% <ø> (+3.70%) ⬆️
jina/drivers/evaluate.py 98.27% <ø> (ø)
jina/drivers/predict.py 89.65% <ø> (ø)
jina/drivers/querylang/queryset/dunderkey.py 100.00% <ø> (ø)
jina/drivers/querylang/queryset/helper.py 92.30% <ø> (ø)
jina/drivers/querylang/queryset/lookup.py 84.21% <ø> (ø)
jina/drivers/querylang/select.py 89.65% <ø> (ø)
jina/drivers/querylang/slice.py 93.75% <ø> (ø)
jina/drivers/querylang/sort.py 100.00% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7222b...8654fe3. Read the comment docs.

@cristianmtr cristianmtr force-pushed the docs-drivers-docstring branch 2 times, most recently from 4767da8 to 5947c60 Compare February 9, 2021 16:03
@jina-bot jina-bot added size/M and removed size/S labels Feb 9, 2021
@github-actions
Copy link
github-actions bot commented Feb 9, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1230, delta to last 3 avg.: +0%
  • 😶 query QPS at 22, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1230 22
0.9.33 1228 22

Backed by latency-tracking. Further commits will update this comment.

@cristianmtr cristianmtr requested a review from JoanFM February 9, 2021 16:13
@cristianmtr cristianmtr force-pushed the docs-drivers-docstring branch from 857cdcb to 8654fe3 Compare February 9, 2021 16:27
@cristianmtr cristianmtr marked this pull request as ready for review February 9, 2021 16:28
@cristianmtr cristianmtr requested a review from a team as a code owner February 9, 2021 16:28
@hanxiao hanxiao merged commit 30ada30 into master Feb 9, 2021
@hanxiao hanxiao deleted the docs-drivers-docstring branch February 9, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM Awaiting requested review from JoanFM

@Roshanjossey Roshanjossey Awaiting requested review from Roshanjossey

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/driver size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristianmtr @JoanFM @hanxiao @jina-bot
0