10000 fix: size assertion for first add call by maximilianwerk · Pull Request #1905 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: size assertion for first add call #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2021
Merged

fix: size assertion for first add call #1905

merged 1 commit into from
Feb 9, 2021
+12 −2

Conversation

maximilianwerk
Copy link
Member

Before this change, a mismatch between vector and key shapes during the very first add call would not have raised the ValueError.

@maximilianwerk maximilianwerk requested a review from a team as a code owner February 8, 2021 21:31
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/executor executor/indexer labels Feb 8, 2021
@maximilianwerk maximilianwerk force-pushed the fix-size-assertiona-for-first-add-call branch from 6579ae9 to 687ee3a Compare February 8, 2021 21:35
@codecov
Copy link
codecov bot commented Feb 8, 2021 •
edited
Loading

Codecov Report

Merging #1905 (8989d47) into master (6bb0ede) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1905      +/-   ##
==========================================
+ Coverage   86.36%   86.37%   +0.01%     
==========================================
  Files         148      148              
  Lines        7069     7069              
==========================================
+ Hits         6105     6106       +1     
+ Misses        964      963       -1
Impacted Files Coverage Δ
jina/executors/indexers/vector.py 94.27% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb0ede...687ee3a. Read the comment docs.

@jina-bot jina-bot added size/S area/testing This issue/PR affects testing and removed size/XS labels Feb 8, 2021
@github-actions
Copy link
github-actions bot commented Feb 8, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 891, delta to last 3 avg.: +2%
  • 😶 query QPS at 14, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 891 14
0.9.31 868 14

Backed by latency-tracking. Further commits will update this comment.

nan-wang
nan-wang approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit bbf5d7c into master Feb 9, 2021
@nan-wang nan-wang deleted the fix-size-assertiona-for-first-add-call branch February 9, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/indexer size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximilianwerk @nan-wang @jina-bot
0