8000 feat(hub): expose jina version in hub list cli #1885 by deepankarm · Pull Request #1890 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(hub): expose jina version in hub list cli #1885 #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2021
Merged

feat(hub): expose jina version in hub list cli #1885 #1890

merged 1 commit into from
Feb 7, 2021

Conversation

deepankarm
Copy link
Contributor
@deepankarm deepankarm commented Feb 7, 2021 •
edited by nan-wang
Loading

image

resolved #1885

@deepankarm deepankarm requested a review from a team as a code owner February 7, 2021 08:43
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/docker labels Feb 7, 2021
@codecov
Copy link
codecov bot commented Feb 7, 2021 •
edited
Loading

Codecov Report

Merging #1890 (6f4bd5f) into master (a31a475) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1890   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files         147      147           
  Lines        7015     7016    +1     
=======================================
+ Hits         6053     6054    +1     
  Misses        962      962
Impacted Files Coverage Δ
jina/docker/hubapi/local.py 88.50% <100.00%> (+0.13%) ⬆️
jina/logging/pipe.py 0.00% <0.00%> (ø)
jina/logging/logger.py 82.40% <0.00%> (ø)
jina/logging/profile.py 70.40% <0.00%> (ø)
jina/logging/formatter.py 73.52% <0.00%> (ø)
jina/peapods/runtimes/jinad/client.py 82.35% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529e10e...6f4bd5f. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 7, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1009, delta to last 3 avg.: -1%
  • 😶 query QPS at 19, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1009 19
0.9.30 1028 19
0.9.29 1018 19

Backed by latency-tracking. Further commits will update this comment.

nan-wang
nan-wang approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 4008fa7 into master Feb 7, 2021
@nan-wang nan-wang deleted the add-jina-version-to-hublist branch February 7, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@davidbp davidbp Awaiting requested review from davidbp

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/docker size/S
Projects
None yet
Milestone
No milestone
Development
3E64

Successfully merging this pull request may close these issues.

Expose jina-version in jina hub list
3 participants
@deepankarm @nan-wang @jina-bot
0