8000 fix(daemon): remove all from endpoints by deepankarm · Pull Request #1880 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(daemon): remove all from endpoints #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2021
Merged

fix(daemon): remove all from endpoints #1880

merged 3 commits into from
Feb 7, 2021

Conversation

deepankarm
Copy link
Contributor

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner February 5, 2021 15:59
deepankarm
deepankarm commented Feb 5, 2021
View reviewed changes
jina/peapods/runtimes/jinad/client.py
# set timeout to None if args.timeout_ready is -1 (wait forever)
r = requests.post(url=self.store_api,
json=payload,
timeout=args.timeout_ready if args.timeout_ready != -1 else None)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoanFM changed #1879 here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u make sure, that if -1 is sent, and the Pea fails to start in the other end, the Exception is sent in response?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the remote Pea fails to start, we'll capture the exception in r.json()

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/daemon area/network This issue/PR affects network functionality component/peapod labels Feb 5, 2021
@codecov
Copy link
codecov bot commented Feb 5, 2021 •
edited
Loading

Codecov Report

Merging #1880 (497ef82) into master (97c6b59) will increase coverage by 0.30%.
The diff coverage is 80.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
+ Coverage   86.04%   86.35%   +0.30%     
==========================================
  Files         146      147       +1     
  Lines        6982     7015      +33     
==========================================
+ Hits         6008     6058      +50     
+ Misses        974      957      -17
Impacted Files Coverage Δ
jina/clients/asyncio.py 90.90% <ø> (+3.03%) ⬆️
jina/helloworld/__init__.py 100.00% <ø> (ø)
jina/optimizers/parameters.py 97.50% <50.00%> (-2.50%) ⬇️
jina/flow/mixin/async_crud.py 59.45% <59.45%> (ø)
jina/clients/sugary_io.py 92.10% <88.88%> (-4.26%) ⬇️
jina/flow/mixin/crud.py 89.28% <89.28%> (ø)
jina/drivers/index.py 96.55% <92.30%> (-3.45%) ⬇️
jina/clients/request/helper.py 97.95% <100.00%> (+0.04%) ⬆️
jina/drivers/encode.py 95.00% <100.00%> (+0.17%) ⬆️
jina/executors/indexers/cache.py 98.50% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c6b59...cec1f6e. Read the comment docs.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Feb 7, 2021
@github-actions
Copy link
github-actions bot commented Feb 7, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1192, delta to last 3 avg.: -2%
  • 😶 query QPS at 23, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1192 23
0.9.30 1230 23
0.9.29 1226 23

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 7265d21 into master Feb 7, 2021
@hanxiao hanxiao deleted the daemon-endpoints-cleanup branch February 7, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@JoanFM JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepankarm @hanxiao @JoanFM @jina-bot
0