8000 refactor(driver): set default len 36, move check to driver by hanxiao · Pull Request #1887 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(driver): set default len 36, move check to driver #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2021
Merged

refactor(driver): set default len 36, move check to driver #1887

merged 2 commits into from
Feb 6, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Feb 6, 2021
  • uuid1 (default doc_id) is 36, therefore default_length needs to be 36
  • no need do property for simple get/set
  • move check to driver

@hanxiao hanxiao requested a review from a team as a code owner February 6, 2021 19:50
@codecov
Copy link
codecov bot commented Feb 6, 2021 •
edited
Loading

Codecov Report

Merging #1887 (5adbee3) into master (8aed8f6) will decrease coverage by 22.19%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1887       +/-   ##
===========================================
- Coverage   86.32%   64.13%   -22.20%     
===========================================
  Files         147      147               
  Lines        7007     7015        +8     
===========================================
- Hits         6049     4499     -1550     
- Misses        958     2516     +1558
Impacted Files Coverage Δ
jina/drivers/index.py 93.10% <92.30%> (-6.90%) ⬇️
jina/executors/indexers/keyvalue.py 100.00% <100.00%> (ø)
jina/executors/indexers/vector.py 87.43% <100.00%> (-6.32%) ⬇️
jina/helloworld/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/components.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aed8f6...2522b05. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 6, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 896, delta to last 3 avg.: -10%
  • 🐢🐢 query QPS at 15, delta to last 3 avg.: -11%

Breakdown

Version Index QPS Query QPS
current 896 15
0.9.29 932 15
0.9.28 1060 18

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 6716be2 into master Feb 6, 2021
@hanxiao hanxiao deleted the refactor-driver-len-check branch February 6, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/driver component/executor executor/indexer size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0