8000 docs: updated optimizer docstrings by maximilianwerk · Pull Request #1876 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: updated optimizer docstrings #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2021
Merged

docs: updated optimizer docstrings #1876

merged 3 commits into from
Feb 6, 2021

Conversation

maximilianwerk
Copy link
Member

Cleanup of optimizer docstrings according to sphinx style.

@maximilianwerk maximilianwerk requested a review from a team as a code owner February 5, 2021 10:43
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase labels Feb 5, 2021
@codecov
Copy link
codecov bot commented Feb 5, 2021 •
edited
Loading

Codecov Report

Merging #1876 (f6add08) into master (4e1db76) will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
+ Coverage   86.20%   86.32%   +0.11%     
==========================================
  Files         145      145              
  Lines        6925     6927       +2     
==========================================
+ Hits         5970     5980      +10     
+ Misses        955      947       -8
Impacted Files Coverage Δ
jina/optimizers/parameters.py 97.50% <50.00%> (-2.50%) ⬇️
jina/optimizers/flow_runner.py 95.65% <100.00%> (ø)
jina/flow/base.py 88.02% <0.00%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1db76...8d131f4. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 5, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1163, delta to last 3 avg.: -2%
  • 😶 query QPS at 23, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1163 23
0.9.28 1187 23
0.9.27 1203 23

Backed by latency-tracking. Further commits will update this comment.

@maximilianwerk maximilianwerk force-pushed the docs-updated-optimizer-docstrings branch from 5cfed9a to 8d131f4 Compare February 5, 2021 19:12
nan-wang
nan-wang approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit c5e275b into master Feb 6, 2021
@nan-wang nan-wang deleted the docs-updated-optimizer-docstrings branch February 6, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@davidbp davidbp Awaiting requested review from davidbp

@BastinJafari BastinJafari Awaiting requested review from BastinJafari

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximilianwerk @nan-wang @jina-bot
0