8000 refactor: docCache signature fix by JoanFM · Pull Request #1842 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: docCache signature fix #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Feb 3, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner February 3, 2021 12:05
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/executor executor/indexer labels Feb 3, 2021
@github-actions
Copy link
github-actions bot commented Feb 3, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1381, delta to last 3 avg.: -4%
  • 😶 query QPS at 27, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1381 27
0.9.27 1443 26
0.9.26 1448 27

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM force-pushed the fix-cache-signature branch from 76c8295 to 57ca3a7 Compare February 3, 2021 12:19
@JoanFM JoanFM changed the title refactor: DocCache signature fix refactor: docCache signature fix Feb 3, 2021
@codecov
Copy link
codecov bot commented Feb 3, 2021

Codecov Report

Merging #1842 (7925967) into master (f24c4f8) will decrease coverage by 3.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1842      +/-   ##
==========================================
- Coverage   85.85%   82.61%   -3.25%     
==========================================
  Files         145      145              
  Lines        6943     6943              
==========================================
- Hits         5961     5736     -225     
- Misses        982     1207     +225     
Impacted Files Coverage Δ
jina/executors/indexers/cache.py 97.18% <100.00%> (ø)
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/scipy.py 45.00% <0.00%> (-45.00%) ⬇️
jina/types/ndarray/sparse/__init__.py 50.00% <0.00%> (-43.34%) ⬇️
jina/types/document/multimodal.py 56.00% <0.00%> (-42.00%) ⬇️
jina/types/sets/querylang.py 56.45% <0.00%> (-37.10%) ⬇️
jina/types/document/converters.py 60.93% <0.00%> (-35.94%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24c4f8...7925967. Read the comment docs.

@JoanFM JoanFM force-pushed the fix-cache-signature branch from 57ca3a7 to 7925967 Compare February 3, 2021 12:39
@florian-hoenicke florian-hoenicke merged commit 11eb7c9 into master Feb 3, 2021
@florian-hoenicke florian-hoenicke deleted the fix-cache-signature branch February 3, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0