8000 chore: take out dependency on version file from core by bwanglzu · Pull Request #1833 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: take out dependency on version file from core #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

bwanglzu
Copy link
Member
@bwanglzu bwanglzu commented Feb 2, 2021

Dependent on release workflow in docs.

@jina-bot jina-bot added the size/S label Feb 2, 2021
@codecov
Copy link
codecov bot commented Feb 2, 2021

Codecov Report

Merging #1833 (dad483e) into master (171515c) will decrease coverage by 26.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1833       +/-   ##
===========================================
- Coverage   86.01%   59.06%   -26.96%     
===========================================
  Files         145      145               
  Lines        6920     6920               
===========================================
- Hits         5952     4087     -1865     
- Misses        968     2833     +1865     
Impacted Files Coverage Δ
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/list.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/build.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/login.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/optimizer.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/helloworld.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/pushpull.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171515c...dad483e. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 2, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1209, delta to last 3 avg.: -1%
  • 🐢🐢 query QPS at 23, delta to last 3 avg.: -28%

Breakdown

Version Index QPS Query QPS
current 1209 23
0.9.24 1226 32
0.9.23 1220 31

Backed by latency-tracking. Further commits will update this comment.

@bwanglzu bwanglzu marked this pull request as ready for review February 2, 2021 10:59
@bwanglzu bwanglzu requested a review from a team as a code owner February 2, 2021 10:59
@bwanglzu bwanglzu self-assigned this Feb 2, 2021
@bwanglzu bwanglzu changed the title chore: take out release version from core chore: take out dependency on version file from core Feb 2, 2021
@hanxiao hanxiao merged commit c1f7997 into master Feb 2, 2021
@hanxiao hanxiao deleted the chore-update-release-version branch February 2, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0