8000 feat(rest): add protobuf model to pydantic by hanxiao · Pull Request #1835 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(rest): add protobuf model to pydantic #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2021
Merged

feat(rest): add protobuf model to pydantic #1835

merged 1 commit into from
Feb 2, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Feb 2, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 2, 2021 12:41
@hanxiao hanxiao requested review from cristianmtr and JoanFM February 2, 2021 12:41
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/daemon area/network This issue/PR affects network functionality component/peapod labels Feb 2, 2021
@codecov
Copy link
codecov bot commented Feb 2, 2021 •
edited
Loading

Codecov Report

Merging #1835 (060f8b5) into master (b05a0a3) will decrease coverage by 0.09%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
- Coverage   86.08%   85.98%   -0.10%     
==========================================
  Files         145      145              
  Lines        6920     6935      +15     
==========================================
+ Hits         5957     5963       +6     
- Misses        963      972       +9
Impacted Files Coverage Δ
jina/peapods/runtimes/asyncio/rest/app.py 77.55% <42.85%> (-2.17%) ⬇️
jina/peapods/runtimes/asyncio/rest/models.py 100.00% <100.00%> (ø)
jina/peapods/runtimes/jinad/client.py 75.00% <0.00%> (-5.15%) ⬇️
jina/drivers/querylang/select.py 89.65% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b05a0a3...060f8b5. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Feb 2, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1137, delta to last 3 avg.: -3%
  • 🐢🐢 query QPS at 19, delta to last 3 avg.: -29%

Breakdown

Version Index QPS Query QPS
current 1137 19
0.9.24 1181 27
0.9.23 1180 26

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 6fc0574 into master Feb 2, 2021
@hanxiao hanxiao deleted the feat-pydantic-ob branch February 2, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0