fix: vector indexer only uses str as keys #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1829 +/- ##
==========================================
+ Coverage 85.86% 86.05% +0.19%
==========================================
Files 145 145
Lines 6924 6920 -4
==========================================
+ Hits 5945 5955 +10
+ Misses 979 965 -14
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
hanxiao
approved these changes
Feb 1, 2021
This was referenced Feb 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes #1606
keysinside theNumpyIndexerare not always of typestr. I am not sure, whether it should beIterator[str],Iterable[str],Sequence[str]or simplyList[str]though. Input would be highly appreciated.query_by_id=>query_by_keyto keep consistency.def query(keys:...=>def query(query_vectors, ...Furthermore, I changed the interface of the
deletefunction to also usestrinstead ofint. Not sure about this change as well.Quite a few hub changes must be done after this PR is merged in order to keep all hub indexer in sync with this PR.