8000 feat: crud asyncio by florian-hoenicke · Pull Request #1810 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: crud asyncio #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2021
Merged

feat: crud asyncio #1810

merged 1 commit into from
Jan 28, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 28, 2021 22:51
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client component/flow labels Jan 28, 2021
@codecov
Copy link
codecov bot commented Jan 28, 2021 •
edited
Loading

Codecov Report

Merging #1810 (117957c) into master (923c1bd) will decrease coverage by 17.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1810       +/-   ##
===========================================
- Coverage   85.61%   67.78%   -17.84%     
===========================================
  Files         136      136               
  Lines        6939     6953       +14     
===========================================
- Hits         5941     4713     -1228     
- Misses        998     2240     +1242
Impacted Files Coverage Δ
jina/clients/asyncio.py 92.30% <100.00%> (+14.52%) ⬆️
jina/flow/asyncio.py 76.00% <100.00%> (+7.81%) ⬆️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-95.66%) ⬇️
jina/docker/hubapi/local.py 0.00% <0.00%> (-88.38%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923c1bd...5a8d4ac. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1114, delta to last 3 avg.: +0%
  • 😶 query QPS at 25, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1114 25
0.9.22 1110 25
0.9.21 1097 25

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 300931a into master Jan 28, 2021
@hanxiao hanxiao deleted the feat-crud-asyncio branch January 28, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang Awaiting requested review from nan-wang

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client component/flow size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florian-hoenicke @hanxiao @jina-bot
0